Fix Alert not rendering in dark theme if XamlRoot or window is dark #8777
Conversation
| @@ -71,6 +74,22 @@ void Alert::ProcessPendingAlertRequests() noexcept { | |||
| } | |||
| } | |||
|
|
|||
| // Workaround XAML bug with ContentDialog and dark theme: | |||
| // https://github.com/microsoft/microsoft-ui-xaml/issues/2331 | |||
| dialog.Opened([useXamlRootForThemeBugWorkaround](winrt::IInspectable const &sender, auto &&) { | |||
There was a problem hiding this comment.
this only repros in islands, right? if so, we should only do this dance if the app is an islands app, there are some helpers we use elsewhere for detecting this
There was a problem hiding this comment.
It's not only Islands. You can see the bug (and fix) in UWP in screenshots above.
|
@msftbot merge in 48 hours |
ghost
added
the
AutoMerge
|
Hello @NickGerleman! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
This works around XAML bug microsoft/microsoft-ui-xaml#2331. It happens if a Window or XamlRoot's Content element has RequestedTheme set to Dark and then you open a ContentDialog in that window. To workaround we explicitly set the RequestedTheme on the Popup.
To test I have my OS color set to light, run playground app, set the theme to dark in the app, then open an Alert.
Before playground-win32:
After playground-win32:
Before playground (UWP):
After playground (UWP):
Microsoft Reviewers: Open in CodeFlow